An extension that relaxes the constant address space requirement of printf format strings and string args#148
Merged
johnkslang merged 4 commits intoKhronosGroup:mainfrom Jul 27, 2022
Merged
Conversation
raunraun
reviewed
Jun 29, 2022
MrSidims
pushed a commit
to MrSidims/SPIRV-LLVM-Translator
that referenced
this pull request
Nov 30, 2022
The extension was added in KhronosGroup/SPIRV-Registry#148 Starting from this PR SPV_INTEL_non_constant_addrspace_printf will be step by step deprecated. Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
MrSidims
pushed a commit
to MrSidims/SPIRV-LLVM-Translator
that referenced
this pull request
Nov 30, 2022
The extension was added in KhronosGroup/SPIRV-Registry#148 Starting from this PR SPV_INTEL_non_constant_addrspace_printf will be step by step deprecated. Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
MrSidims
pushed a commit
to KhronosGroup/SPIRV-LLVM-Translator
that referenced
this pull request
Dec 2, 2022
The extension was added in KhronosGroup/SPIRV-Registry#148 Starting from this PR SPV_INTEL_non_constant_addrspace_printf will be step by step deprecated. Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
Fznamznon
pushed a commit
to Fznamznon/llvm
that referenced
this pull request
Dec 5, 2022
The extension was added in KhronosGroup/SPIRV-Registry#148 Starting from this PR SPV_INTEL_non_constant_addrspace_printf will be step by step deprecated. Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com> Original commit: KhronosGroup/SPIRV-LLVM-Translator@a9391f7
vmaksimo
pushed a commit
to vmaksimo/SPIRV-LLVM-Translator
that referenced
this pull request
Jan 19, 2023
…nsion The original change: KhronosGroup#1749 The extension was added in KhronosGroup/SPIRV-Registry#148 Starting from this PR SPV_INTEL_non_constant_addrspace_printf will be step by step deprecated. Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
vmaksimo
pushed a commit
to vmaksimo/SPIRV-LLVM-Translator
that referenced
this pull request
Jan 19, 2023
The original change KhronosGroup#1749 The extension was added in KhronosGroup/SPIRV-Registry#148 Starting from this PR SPV_INTEL_non_constant_addrspace_printf will be step by step deprecated. Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
vmaksimo
added a commit
to vmaksimo/SPIRV-LLVM-Translator
that referenced
this pull request
Jan 23, 2023
…extension This backport is a squash of KhronosGroup#1364, KhronosGroup#1749, KhronosGroup#1818 The extension was added in KhronosGroup/SPIRV-Registry#148
vmaksimo
added a commit
to vmaksimo/SPIRV-LLVM-Translator
that referenced
this pull request
Jan 23, 2023
…extension This backport is a squash of KhronosGroup#1364, KhronosGroup#1749, KhronosGroup#1818 The extension was added in KhronosGroup/SPIRV-Registry#148
vmaksimo
added a commit
to vmaksimo/SPIRV-LLVM-Translator
that referenced
this pull request
Jan 23, 2023
…xtension This backport is a squash of KhronosGroup#1364, KhronosGroup#1749, KhronosGroup#1818 The extension was added in KhronosGroup/SPIRV-Registry#148
vmaksimo
added a commit
to vmaksimo/SPIRV-LLVM-Translator
that referenced
this pull request
Jan 23, 2023
…xtension This backport is a squash of KhronosGroup#1364, KhronosGroup#1749, KhronosGroup#1818 The extension was added in KhronosGroup/SPIRV-Registry#148
MrSidims
pushed a commit
to KhronosGroup/SPIRV-LLVM-Translator
that referenced
this pull request
Jan 24, 2023
…nsion The original change: #1749 The extension was added in KhronosGroup/SPIRV-Registry#148 Starting from this PR SPV_INTEL_non_constant_addrspace_printf will be step by step deprecated. Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
MrSidims
pushed a commit
to KhronosGroup/SPIRV-LLVM-Translator
that referenced
this pull request
Jan 24, 2023
…extension (#1819) This backport is a squash of #1364, #1749, #1818 The extension was added in KhronosGroup/SPIRV-Registry#148
MrSidims
pushed a commit
to KhronosGroup/SPIRV-LLVM-Translator
that referenced
this pull request
Jan 24, 2023
…extension (#1820) This backport is a squash of #1364, #1749, #1818 The extension was added in KhronosGroup/SPIRV-Registry#148
MrSidims
pushed a commit
to KhronosGroup/SPIRV-LLVM-Translator
that referenced
this pull request
Jan 26, 2023
The original change #1749 The extension was added in KhronosGroup/SPIRV-Registry#148 Starting from this PR SPV_INTEL_non_constant_addrspace_printf will be step by step deprecated. Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
MrSidims
pushed a commit
to KhronosGroup/SPIRV-LLVM-Translator
that referenced
this pull request
Jan 26, 2023
…xtension (#1821) This backport is a squash of #1364, #1749, #1818 The extension was added in KhronosGroup/SPIRV-Registry#148
vmaksimo
added a commit
to vmaksimo/SPIRV-LLVM-Translator
that referenced
this pull request
Feb 3, 2023
…xtension This backport is a squash of KhronosGroup#1364, KhronosGroup#1749, KhronosGroup#1818 The extension was added in KhronosGroup/SPIRV-Registry#148
vmaksimo
added a commit
to vmaksimo/SPIRV-LLVM-Translator
that referenced
this pull request
Feb 6, 2023
…xtension This backport is a squash of KhronosGroup#1364, KhronosGroup#1749, KhronosGroup#1818 The extension was added in KhronosGroup/SPIRV-Registry#148
vmaksimo
added a commit
to vmaksimo/SPIRV-LLVM-Translator
that referenced
this pull request
Feb 8, 2023
…xtension This backport is a squash of KhronosGroup#1364, KhronosGroup#1749, KhronosGroup#1818 The extension was added in KhronosGroup/SPIRV-Registry#148
MrSidims
pushed a commit
to KhronosGroup/SPIRV-LLVM-Translator
that referenced
this pull request
Feb 8, 2023
…xtension This backport is a squash of #1364, #1749, #1818 The extension was added in KhronosGroup/SPIRV-Registry#148
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The key motivation for this extension is to minimize the need for modifications of codes using printf when moving between host and device, and to support running CUDA/HIP-based kernels which call a more relaxed printf (that in fact delegates from the device to host printf, whatever that happens to be).
The OpenCL C part is in KhronosGroup/OpenCL-Docs#807.